pre-commit
/
pre-commit-hooks
mirror of https://github.com/pre-commit/pre-commit-hooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Stop pkg_resources from being added as well 

This package with an underscore instead of a dash seems to be
new behavior (at least on Ubuntu 20.04 with Python 3.8)

fixes #1030
This commit is contained in:
Eric L Frederich 2022-12-14 10:35:51 -05:00
parent 6afc57465d
commit eadcce2e03
No known key found for this signature in database
GPG Key ID: 9F2136932FBB7EAC
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pre_commit_hooks/requirements_txt_fixer.py
View File

@ -115,7 +115,10 @@ def fix_requirements(f: IO[bytes]) -> int:
# which is automatically added by broken pip package under Debian # which is automatically added by broken pip package under Debian
requirements = [ requirements = [
req for req in requirements req for req in requirements
if req.value != b'pkg-resources==0.0.0\n' if req.value not in [
b'pkg-resources==0.0.0\n',
b'pkg_resources==0.0.0\n',
]
] ]
# sort the requirements and remove duplicates # sort the requirements and remove duplicates

2
tests/requirements_txt_fixer_test.py
View File

@ -82,6 +82,8 @@ from pre_commit_hooks.requirements_txt_fixer import Requirement
), ),
(b'bar\npkg-resources==0.0.0\nfoo\n', FAIL, b'bar\nfoo\n'), (b'bar\npkg-resources==0.0.0\nfoo\n', FAIL, b'bar\nfoo\n'),
(b'foo\npkg-resources==0.0.0\nbar\n', FAIL, b'bar\nfoo\n'), (b'foo\npkg-resources==0.0.0\nbar\n', FAIL, b'bar\nfoo\n'),
(b'bar\npkg_resources==0.0.0\nfoo\n', FAIL, b'bar\nfoo\n'),
(b'foo\npkg_resources==0.0.0\nbar\n', FAIL, b'bar\nfoo\n'),
( (
b'git+ssh://git_url@tag#egg=ocflib\nDjango\nijk\n', b'git+ssh://git_url@tag#egg=ocflib\nDjango\nijk\n',
FAIL, FAIL,