check-json: resolve TODO
This commit is contained in:
parent
66250ba9bf
commit
c11c5483d6
|
@ -14,8 +14,7 @@ def main(argv: Optional[Sequence[str]] = None) -> int:
|
|||
with open(filename, 'rb') as f:
|
||||
try:
|
||||
json.load(f)
|
||||
# TODO: need UnicodeDecodeError?
|
||||
except (ValueError, UnicodeDecodeError) as exc:
|
||||
except ValueError as exc:
|
||||
print(f'{filename}: Failed to json decode ({exc})')
|
||||
retval = 1
|
||||
return retval
|
||||
|
|
|
@ -17,3 +17,9 @@ def test_main(capsys, filename, expected_retval):
|
|||
if expected_retval == 1:
|
||||
stdout, _ = capsys.readouterr()
|
||||
assert filename in stdout
|
||||
|
||||
|
||||
def test_non_utf8_file(tmpdir):
|
||||
f = tmpdir.join('t.json')
|
||||
f.write_binary(b'\xa9\xfe\x12')
|
||||
assert main((str(f),))
|
||||
|
|
Loading…
Reference in New Issue