docker
/
buildx
mirror of https://github.com/docker/buildx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: toControllerOptions: micro-optimization 

Swapping the order of these checks, which I guess is the most minimal
optimization possible

    BenchmarkGetEnv-10    68764720    16.82  ns/op   0 B/op   0 allocs/op
    BenchmarkMap-10      454135184     2.635 ns/op   0 B/op   0 allocs/op

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2023-06-23 12:36:37 +02:00
parent 63eb73d9cf
commit a4da7661ff
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
commands/build.go
View File

@ -145,8 +145,8 @@ func (o *buildOptions) toControllerOptions() (*controllerapi.BuildOptions, error
} }
// TODO: extract env var parsing to a method easily usable by library consumers // TODO: extract env var parsing to a method easily usable by library consumers
if v := os.Getenv("SOURCE_DATE_EPOCH"); v != "" { if _, ok := opts.BuildArgs["SOURCE_DATE_EPOCH"]; !ok {
if _, ok := opts.BuildArgs["SOURCE_DATE_EPOCH"]; !ok { if v := os.Getenv("SOURCE_DATE_EPOCH"); v != "" {
opts.BuildArgs["SOURCE_DATE_EPOCH"] = v opts.BuildArgs["SOURCE_DATE_EPOCH"] = v
} }
} }