docker
/
buildx
mirror of https://github.com/docker/buildx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

debug: print error message on monitor instead of processes pkg 

This can catch and print more errors on monitor side not only process-related
errors.

Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
This commit is contained in:
Kohei Tokunaga 2023-10-18 12:28:14 +09:00
parent 267e30a19c
commit 14834e6085
No known key found for this signature in database
GPG Key ID: 6CE0A04690DB3FB3
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
controller/processes/processes.go
View File

@ -137,11 +137,7 @@ func (m *Manager) StartProcess(pid string, resultCtx *build.ResultHandle, cfg *p
go func() { go func() {
var err error var err error
if err = ctr.Exec(ctx, cfg, in.Stdin, in.Stdout, in.Stderr); err != nil { if err = ctr.Exec(ctx, cfg, in.Stdin, in.Stdout, in.Stderr); err != nil {
if errors.Is(err, context.Canceled) { logrus.Debugf("process error: %v", err)
logrus.Debugf("process canceled: %v", err)
} else {
logrus.Errorf("failed to exec process: %v", err)
}
} }
logrus.Debugf("finished process %s %v", pid, cfg.Entrypoint) logrus.Debugf("finished process %s %v", pid, cfg.Entrypoint)
m.processes.Delete(pid) m.processes.Delete(pid)

6
monitor/monitor.go
View File

@ -302,7 +302,11 @@ func (m *monitor) startInvoke(ctx context.Context, pid string, cfg controllerapi
go func() { go func() {
// Start a new invoke // Start a new invoke
if err := m.invoke(ctx, pid, cfg); err != nil { if err := m.invoke(ctx, pid, cfg); err != nil {
logrus.Debugf("invoke error: %v", err) if errors.Is(err, context.Canceled) {
logrus.Debugf("process canceled: %v", err)
} else {
logrus.Errorf("invoke: %v", err)
}
} }
if pid == m.attachedPid.Load() { if pid == m.attachedPid.Load() {
m.attachedPid.Store("") m.attachedPid.Store("")