docker
/
buildx
mirror of https://github.com/docker/buildx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bake: fix testing json formatted output 

Because the test checked for combinedoutput, it
could contain internal warning messages in stderr.
JSON output is guaranteed in stdout.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This commit is contained in:
Tonis Tiigi 2024-07-08 18:31:27 -07:00
parent 68076909b9
commit 0f74f9a794
No known key found for this signature in database
GPG Key ID: AFA9DE5F8AB7AF39
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/bake.go
View File

@ -1074,15 +1074,16 @@ target "another" {
require.Contains(t, out, "another")
require.Contains(t, out, "UndefinedVar")
out, err = bakeCmd(
cmd := buildxCmd(
sb,
withDir(dir),
withArgs("build", "another", "--call", "check,format=json"),
withArgs("bake", "--progress=quiet", "build", "another", "--call", "check,format=json"),
)
require.Error(t, err, out)
outB, err := cmd.Output()
require.Error(t, err, string(outB))
var res map[string]any
err = json.Unmarshal([]byte(out), &res)
err = json.Unmarshal(outB, &res)
require.NoError(t, err, out)
targets, ok := res["target"].(map[string]any)